Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable JMX credentials backend #809

Closed
denniskline opened this issue Dec 9, 2019 · 2 comments
Closed

Pluggable JMX credentials backend #809

denniskline opened this issue Dec 9, 2019 · 2 comments

Comments

@denniskline
Copy link
Contributor

Provide a mechanism for allowing reaper users to define where/how the JMX credentials are stored.

This was briefly discussed as part of issue 143: #143

When reaper is used to orchestrate repairs across many clusters where clusters are added and removed often and each cluster has different JMX credentials, it is cumbersome to make modifications to the config.yaml on all the running instances of reaper and then restart each instance to pick up the change.

It would be great if there were options for users to be able to choose where reaper pulled JMX credentials. Reaper would also need the ability to be able to pull in new JmxCredentials as they are added.

Along these lines (and perhaps this should be split into a different issue), it would also be nice if these JMX credentials could be encrypted as leaving them as plain text raises red flags with audit it some companies.

If this is something that the community would like, I'd be more than happy to contribute to this issue

@adejanovski
Copy link
Contributor

Hi @denniskline,

we sure need something like this because what we have now is faaaaar from agile (and not secured much).
We've evolved the format of the cluster table to allow storing more cluster specific data in the properties column (right now just the JMX port). It would be a great place to store the encrypted credentials.
I think a single issue should cover both as storing unencrypted credentials is probably not something we want to do.

We would love to have a contribution on this 😍
Let us know if we can help you in any way.

@denniskline
Copy link
Contributor Author

@adejanovski - That's great news! I'll take a stab at it and keep this issue thread updated with questions along the way. Thank you very much.

denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Dec 20, 2019
…ngside JMX Port in the backend storage system.
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 3, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 3, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 3, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 3, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 12, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 12, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
…ngside JMX Port in the backend storage system.
denniskline pushed a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
…ngside JMX Port in the backend storage system.
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 15, 2020
…ngside JMX Port in the backend storage system.
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 28, 2020
…ngside JMX Port in the backend storage system.
denniskline added a commit to denniskline/cassandra-reaper that referenced this issue Jan 29, 2020
…ngside JMX Port in the backend storage system.
adejanovski pushed a commit that referenced this issue Jan 30, 2020
adejanovski pushed a commit that referenced this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants