Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set segment count per node to consistent value across defaults and docs #1477

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Set segment count per node to consistent value across defaults and docs #1477

merged 4 commits into from
Mar 11, 2024

Commits on Mar 9, 2024

  1. Set segment count per node to consistent value across defaults and docs 

    Per thelastpickle#1192
the default should be 64.  So, set that everywhere, including docs
    @SesquipedalianDefenestrator
    SesquipedalianDefenestrator committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    c77de30 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Also fix test that assumed 16-segment default

    @SesquipedalianDefenestrator
    SesquipedalianDefenestrator committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    354d14e View commit details
    Browse the repository at this point in the history

  2. Properly fix computeGlobalSegmentCount256TokenPerNodeTest 

    After reading the actual function, this makes more sense as a fix.
    @SesquipedalianDefenestrator
    SesquipedalianDefenestrator committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    39ae32e View commit details
    Browse the repository at this point in the history

  3. Also fix computeGlobalSegmentCountSingleTokenPerNodeTest

    @SesquipedalianDefenestrator
    SesquipedalianDefenestrator committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    427acc1 View commit details
    Browse the repository at this point in the history