DRY: Don't Repeat Yourself #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works since doing an empty return is the same as not doing a return at all in javascript
* Removed “addHeaders” and made repeatable calls to “withHeaders” possible * Made withAuth part of the request builder
|
Any input @JMPerez? :) |
|
@brodin Sorry for the late reply. I haven't had time to look into the PRs, and I'm currently looking for adding more maintainers to the project. I like your approach. It's way cleaner and it would make the library lighter and easier to work with. Do you think you'll be able to resolve the conflicts? |
|
@JMPerez resolved the conflicts now – what do you think? :) |
|
@brodin It looks great! I'm going to merge it. |
atoami
pushed a commit
to atoami/react-native-spotify-web-api
that referenced
this pull request
Oct 20, 2018
* Moved the optional callback logic to "performRequest" * Refactored header and auth request bulding * Removed “addHeaders” and made repeatable calls to “withHeaders” possible * Made withAuth part of the request builder * Refactored legacy options/callback handler * Don't assign empty object * Refactored query parameters handling * Refactored body parameters handling * Allow multiple arguments to with[body|Query|Headers] builders * Made token part of WebApiRequest builder * A built request can now execute itself * Limit repetition in base-request with factories * Refactored getQueryParameterString and wrote tests for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of this repo, but when I looked at the source code to add some new endpoint I realised that there was a lot of repetion in the code. This PR is an attempt to "dry things up". This will not only reduce the footprint of the library, but hopefully make it easier to add and maintain endpoints in the future.
Some of the things I have done:
add[headers|QueryParamaters|BodyParameter]. This made the built request into a true immutable. This was accomplished by making thewith[Headers|BodyParameter|QueryParamater]functions more intelligent.Request(handling both callbacks and promises)WebApiRequestas a default.What do you guys think? This was kind of a step-by-step refactor, do you want me to squash some of the commits? :)