Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov and snapshot test #29

Merged
merged 7 commits into from
Feb 20, 2019
Merged

Add codecov and snapshot test #29

merged 7 commits into from
Feb 20, 2019

Conversation

guoliu
Copy link
Contributor

@guoliu guoliu commented Feb 18, 2019

As title.

Notes:

@guoliu guoliu added the WIP label Feb 18, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@86e4508). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #29   +/-   ##
==========================================
  Coverage           ?   61.25%           
==========================================
  Files              ?       26           
  Lines              ?      240           
  Branches           ?       64           
==========================================
  Hits               ?      147           
  Misses             ?       76           
  Partials           ?       17
Impacted Files Coverage Δ
components/Avatar/index.tsx 84.61% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e4508...6cf2071. Read the comment docs.

@guoliu guoliu removed the WIP label Feb 19, 2019
@guoliu guoliu changed the title WIP add codecov Add codecov Feb 19, 2019
@guoliu guoliu changed the title Add codecov Add codecov and snapshot test Feb 19, 2019
@guoliu
Copy link
Contributor Author

guoliu commented Feb 19, 2019

(2) code coverage in CI

Copy link
Contributor

@devformatters devformatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🦊

components/Button/index.tsx Outdated Show resolved Hide resolved
@guoliu guoliu merged commit 1d35e7f into develop Feb 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the codecov branch February 20, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants