-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codecov and snapshot test #29
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #29 +/- ##
==========================================
Coverage ? 61.25%
==========================================
Files ? 26
Lines ? 240
Branches ? 64
==========================================
Hits ? 147
Misses ? 76
Partials ? 17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 🦊
As title.
Notes:
ts-jest[versions] (WARN) Version 23.6.0 of babel-jest installed has not been tested with
ts-jest. If you're experiencing issues, consider using a supported version (>=24.0.0 <25.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
This warning will go away if we upgrade babel-jest to >=24.0.0. However, this will break customized plugins, see: feat(jest): bump to 24 kulshekhar/ts-jest#957 (comment) So we have to live with this error untilts-jest
fix the issue.ts-jest
soon, but for the time being it's still better to usets-jest
, since typescript support in Jest/babel is still not comprehensive. See more at: What does the new major release of Jest (24) means for this library kulshekhar/ts-jest#961 and https://kulshekhar.github.io/ts-jest/user/babel7-or-ts