Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuetorrent curl github redirect #535

Merged
merged 9 commits into from
Jan 25, 2024
Merged

vuetorrent curl github redirect #535

merged 9 commits into from
Jan 25, 2024

Conversation

cjLGH
Copy link
Contributor

@cjLGH cjLGH commented Jan 21, 2024

theme-park.dev


  • I have read the contributing guideline and understand that I have made the correct modifications

  • PR's are done against the develop branch.


Bug fixes

Current LSIO docker-mod ghcr.io/themepark-dev/theme.park:vuetorrent for qbittorrent has the output below when attempting to curl for the CURRENT_RELEASE variable because of a redirect against https://api.github.com/repos/WDaan/VueTorrent/releases/latest.

jq: error (at <stdin>:5): Cannot iterate over null (null)
-----------------------------------------
| qBittorrent vuetorrent theme.park Mod |
-----------------------------------------
---------------------------------------
| Downloading WebUI files from github |
---------------------------------------
Downloading qBittorrent webui to "/vuetorrent"..please wait
curl: (2) no URL specified
curl: try 'curl --help' or 'curl --manual' for more information
Download finished
---------------------------------------------------------
| Adding the stylesheet to /vuetorrent/public/index.html |
---------------------------------------------------------
Stylesheet set to space-gray on public index.html

bash output from container during testing

root@8c08aea5b271:/# CURRENT_RELEASE=$(curl -s https://api.github.com/repos/WDaan/VueTorrent/releases/latest | jq -r ".a
ssets[]")
jq: error (at <stdin>:5): Cannot iterate over null (null)

Description:

The curl of the latest vuetorrent repo returns a 301 redirect code and location https://api.github.com/repositories/181508472/releases/latest resulting in a Cannot iterate over null (null) when jq filters assets against the output from the original request. Adding the -L option to the curl command makes it follow a redirect.

Benefits of this PR and context:

Current and future vuetorrent releases may get redirected.

How Has This Been Tested?

Manually.

Source / References:

https://curl.se/docs/manpage.html#-L

GilbN and others added 9 commits May 29, 2023 14:18
* Bad interpreter error associated with the NPM release of 2.9.21 (themepark-dev#486)

* Fix Pi-Hole network details table colors (themepark-dev#489)

* Grafana 9.5.1 element support (themepark-dev#492)

Adding support for only a few elements in latest version of Grafana

* Added uptime kuma card css (themepark-dev#494)

* Use hashlib instead of git shas

* Fix Latest manifest if logic

---------

Co-authored-by: goodbyepavlyi 3 <[email protected]>
Co-authored-by: Samuel Bartík <[email protected]>
Co-authored-by: rg9400 <[email protected]>
Co-authored-by: Henry Whitaker <[email protected]>
* qbittorrent: 💄Fixes for themepark-dev#526

* Unraid: Fix login script github.io URL
Unraid: Fix the navbar scroll overflow.

* Move from subversion to git for pulling the qbittorrent webui (themepark-dev#530)

* Move from subversion to git for pulling the qbittorrent webui

* slight verbage changes

---------

Co-authored-by: Blake <[email protected]>
The curl of the latest vuetorrent repo returns a 301 redirect code and location https://api.github.com/repositories/181508472/releases/latest resulting in a `Cannot iterate over null (null)` when jq filters assets against the output from the original request.
@cjLGH cjLGH changed the base branch from master to develop January 21, 2024 07:26
@GilbN GilbN merged commit cdbce0a into themepark-dev:develop Jan 25, 2024
cjLGH added a commit to cjLGH/theme.park that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants