fix(modal): modal overflowing bottom in chrome on ios #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 99.54% 95.51% -4.04%
==========================================
Files 163 217 +54
Lines 6621 9633 +3012
Branches 401 554 +153
==========================================
+ Hits 6591 9201 +2610
- Misses 30 432 +402 ☔ View full report in Codecov by Sentry. |
DaniloSI
changed the title
DaniloSI
force-pushed
the
fix/modal-overflowing-the-bottom
branch
from
bb153ce
to
c5d0a53
Compare
modal overflowing the bottom in chrome on ios due to not using dynamic viewport units
SutuSebastian
force-pushed
the
fix/modal-overflowing-the-bottom
branch
from
c5d0a53
to
b454afb
Compare
Merged
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal overflowing the bottom in chrome on ios due to not using dynamic viewport units.
I fixed this problem in my personal project by changing the inner prop of modal's theme. This answer helped me.