-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Add @babel/runtime as a dependency #22
Conversation
Signed-off-by: Reece Dunham <[email protected]>
Any timeline on when this will be reviewed, merged, and released? I'm coming from facebook/docusaurus#3003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RDIL, thanks for contribution, but sadly I cannot accept this pull request
as it contains changes outside of the scope.
For that, I recommend you to only add the @babel/runtime
into devDependencies
(not dependencies
itself) and remove all other changes that you made.
Cheers.
@cspotcode per commend above. |
@themgoncalves I can revert the other changes, but this does need to be in normal dependencies, because it imports from the |
From
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RDIL, @ylemkimon you can find this |
Signed-off-by: Reece Dunham [email protected]
Summary
@babel/runtime
as a dependencyWhy
The project currently breaks on Yarn v2 because
@babel/plugin-transform-runtime
calls@babel/runtime
, which is not explicitly declared as one of the project's dependencies.Checklist
errors
orwarnings
approved terminology
unit tests
, if apply.