Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of selecting different from subsets proportionately #270

Merged
merged 12 commits into from
Oct 6, 2024

Conversation

FanwangM
Copy link
Collaborator

@FanwangM FanwangM commented Oct 6, 2024

The original implementation does not support selecting different subest proportionately. This PR addresses that issue.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.17%. Comparing base (90acdfe) to head (fafc517).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
selector/methods/base.py 83.78% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   95.37%   95.17%   -0.21%     
==========================================
  Files           9        9              
  Lines        1017     1037      +20     
==========================================
+ Hits          970      987      +17     
- Misses         47       50       +3     
Files with missing lines Coverage Δ
selector/methods/distance.py 98.12% <100.00%> (+0.67%) ⬆️
selector/methods/partition.py 98.03% <ø> (ø)
selector/methods/base.py 88.67% <83.78%> (-5.77%) ⬇️

@FanwangM FanwangM merged commit 2eb1d7f into theochem:main Oct 6, 2024
15 checks passed
@FanwangM
Copy link
Collaborator Author

FanwangM commented Oct 6, 2024

Some testing examples.
clipboard
clipboard1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant