Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelist of acctests running in Fusioncloud #400

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Conversation

huangtianhua
Copy link
Contributor

Use whitelist to filter the acctests running in Fusioncloud.

Related-Bug: theopenlab/openlab#130

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 2, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 3, 2019

Build succeeded.

# Add OS_DEBUG=1 TF_LOG=debug flags for debuging
echo "$testcases" | xargs -t -n100 sh -c 'OS_DEBUG=1 TF_LOG=debug TF_ACC=1 go test ./huaweicloud/ -v -timeout 300m -run $(echo "$@" | tr " " "|")' argv0 2>&1 | tee -a $TEST_RESULTS_TXT || exitcode=$?

# Run image tests in a separate process to avoid messy output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see that you merged two comments together.
And we should skip VPC peering cases to avoid panic error, that break the following tests, like comments say.
-e TestAccVpcPeeringConnectionV2DataSource_basic -e TestAccVpcRouteIdsV2DataSource_basic -e TestAccVpcRouteV2DataSource_basic

Use whitelist to filter the acctests running in Fusioncloud.

Related-Bug: theopenlab/openlab#130
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 3, 2019

Build succeeded.

Copy link
Contributor

@kiwik kiwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you address my comment

@liusheng
Copy link
Contributor

liusheng commented Jan 4, 2019

LGTM +1

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 4, 2019

Build succeeded.

@liusheng liusheng merged commit ed4725c into master Jan 4, 2019
@liusheng liusheng deleted the whitelist branch January 4, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants