Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out arm64 build job name format #318

Closed
kiwik opened this issue Jul 15, 2019 · 6 comments
Closed

Sort out arm64 build job name format #318

kiwik opened this issue Jul 15, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@kiwik
Copy link
Contributor

kiwik commented Jul 15, 2019

Thank you for reporting bug!

Describe the bug

Some arm64 job names don't apply OpenLab job naming notations, maybe cause some confusion, we should keep consistent for these same type jobs.

Related Job information

If the bug is related a CI job, put the job information below:

  • job name:

    • envoy-build-arm64-test
    • spark-aarch64-build
    • flink-build-and-test-arm64
  • job build log link: NA

  • error log piece: NA

Steps to reproduce the issue

Describe how to reproduce the issue:
See everyday testing log

Additional context

Add any other context about the problem here.

@kiwik kiwik added the bug Something isn't working label Jul 15, 2019
liusheng added a commit to liusheng/openlab-zuul-jobs that referenced this issue Jul 15, 2019
- hbase-arm-build -> hbase-build-aarch64
- hive-build-arm64 -> hive-build-aarch64

Bug: theopenlab/openlab#318
liusheng added a commit to liusheng/openlab-zuul-jobs that referenced this issue Jul 15, 2019
- hbase-arm-build -> hbase-build-aarch64
- hive-build-arm64 -> hive-build-aarch64

Bug: theopenlab/openlab#318
@Yikun
Copy link
Member

Yikun commented Jul 15, 2019

[nodesets.yaml] The nodesets contains some "arm64" [1], it seems we should also change it. But it will break some online CI, so I think blew thing should to be done:

  1. Keep the arm64 and aarch64 at first
  2. Change all nodesets(in job defination) to aarch64.
  3. Remove all arm64.

[1] https://github.com/theopenlab/openlab-zuul-jobs/blob/602ae18c7557588ed43fecc7d8c120d41989cfd9/zuul.d/nodesets.yaml#L27-L37

@ZhengZhenyu
Copy link

The nodesets contains some "arm64" [1], it seems we should also change it. But it will break some online CI, so I think blew thing should to be done:

  1. Keep the arm64 and aarch64 at first
  2. Change all nodesets(in job defination) to aarch64.
  3. Remove all arm64.

[1] https://github.com/theopenlab/openlab-zuul-jobs/blob/602ae18c7557588ed43fecc7d8c120d41989cfd9/zuul.d/nodesets.yaml#L27-L37

Yes, I found this too

@Yikun
Copy link
Member

Yikun commented Jul 15, 2019

Before nodesets.yaml is changed, we also should address nodepool config.

[cloud provider image name]
the vexxhost image should be changed to aarch64

[nodepool.yaml]

  • labels.name: change to ubuntu-xenial-aarch64
  • vexxhost-openlab.cloud-images.name: change to ubuntu-xenial-aarch64
  • vexxhost-openlab.cloud-images.image-name: change to openlab-ubuntu-xenial-aarch64
  • vexxhost-openlab.pools.labels.name: ubuntu-xenial-aarch64
  • vexxhost-openlab.pools.lables.cloud-image: ubuntu-xenial-aarch64

@Yikun
Copy link
Member

Yikun commented Jul 15, 2019

IMO, we should do nodesets.yaml first, and then do the job defination change, otherwise we will require 2 times name format in job.name and job.nodeset . It will bring some confusing on upstream community like containerd, and envoy.

And the otherthing, I didn't see any official announcement in Linux or ARM, anyone found it? Because the project like containerd and envoy jobs are defined in their own repo, and should pr with a convincing proof. (The only thing I can think is that when we type the uname -m or unname -a, the linux name is the aarch64 rather than arm64)

@kiwik kiwik changed the title Sort out aarch64 build job name format Sort out arm64 build job name format Jul 15, 2019
@kiwik
Copy link
Contributor Author

kiwik commented Jul 15, 2019

@Yikun agree, I think arm64 is more readable name for OpenLab jobs and nodeset, so I update issue content, and keep all related jobs to follow the job name format {project}-build-arm64 and nodeset name format {os-name}-arm64

kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jul 15, 2019
1. Change job metadata from aarch64 to arm64
2. Remove useless nodeset "ubuntu-bionic-vxh-arm64"

Related-Bug: theopenlab/openlab#318
kiwik pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jul 18, 2019
* Change ARM jobs according to job naming notitions

- hbase-arm-build -> hbase-build-arm64
- hive-build-arm64 -> hive-build-arm64
- update hbase job description
- use "arm64" instead of "aarch64"

Related-Bug: theopenlab/openlab#318
liusheng pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jul 22, 2019
1. Change job metadata from aarch64 to arm64
2. Remove useless nodeset "ubuntu-bionic-vxh-arm64"

Related-Bug: theopenlab/openlab#318
@huangtianhua
Copy link

I think all related jobs has changed to arm64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants