Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Add aria-controls to attribution toggle and list #446

Merged
merged 1 commit into from
May 8, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented May 8, 2024

What does this PR do?

Introduces aria-controls to attribution collapse button, and corresponding id to attribution list.

@ianjon3s ianjon3s requested a review from a team May 8, 2024 14:49
Copy link

netlify bot commented May 8, 2024

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 6bfe3d6
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/663b910b6e4ad00008cbb0fc
😎 Deploy Preview https://deploy-preview-446--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to map land 🌐 ✨

@ianjon3s ianjon3s merged commit 0206d83 into main May 8, 2024
5 checks passed
@ianjon3s ianjon3s deleted the ian/map-attribute-list-id branch May 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants