Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add data-testid #484

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: add data-testid #484

merged 1 commit into from
Aug 29, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Aug 29, 2024 •
edited
Loading

Changes:

  • Adds dataTestId prop
  • Sets data-testid on the shadow root div only (not containing my-map)

Screenshot from 2024-08-29 13-58-05

@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 4e05af3
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/66d05ce795af5a0008f2b65a
😎 Deploy Preview https://deploy-preview-484--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jessicamcinchak jessicamcinchak requested review from DafyddLlyr and a team August 29, 2024 11:35
DafyddLlyr
DafyddLlyr approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant thank you 👍 Once part of a pre-release I'll re-test in planx-new

@jessicamcinchak jessicamcinchak merged commit 676f0b7 into main Aug 29, 2024
5 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/add-data-testid branch August 29, 2024 13:09
@DafyddLlyr DafyddLlyr mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @DafyddLlyr