Revert "chore: Stream S3 files directly to zip (#2380)" (#2469)

This reverts commit 96adf16.
theopensystemslab · Nov 21, 2023 · 047c8b7 · 047c8b7
1 parent a0284fe
commit 047c8b7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/api.planx.uk/modules/send/utils/exportZip.test.ts b/api.planx.uk/modules/send/utils/exportZip.test.ts
@@ -7,6 +7,7 @@ jest.mock("fs", () => ({
   existsSync: () => true,
   unlinkSync: () => undefined,
   createWriteStream: () => undefined,
+  writeFileSync: () => undefined,
   rmSync: () => undefined,
 }));
 

diff --git a/api.planx.uk/modules/send/utils/exportZip.ts b/api.planx.uk/modules/send/utils/exportZip.ts
@@ -197,7 +197,9 @@ export class ExportZip {
       throw new Error("file not found");
     }
     const filePath = path.join(this.tmpDir, name);
-    this.zip.addFile(filePath, body as Buffer);
+    fs.writeFileSync(filePath, body as Buffer);
+    this.zip.addLocalFile(filePath);
+    fs.unlinkSync(filePath);
   }
 
   toBuffer(): Buffer {