fix: refactor uses of __dirname now that API is using esnext
#3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Aug 13, 2024
| import { fileURLToPath } from "url"; | ||
| import { $api } from "../../../client/index.js"; | ||
| import type { Passport as IPassport } from "../../../types.js"; | ||
| import { getFileFromS3 } from "../../file/service/getFile.js"; |
There was a problem hiding this comment.
this is mostly noise from running "organise imports" in this file, only one new import here which is fileURLToPath
RODO94
approved these changes
Aug 13, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix failing e2e regression tests on
main🤞 https://opensystemslab.slack.com/archives/C04EEBR1E0P/p1723443286868999Regression tests passing against this branch ✅ https://github.com/theopensystemslab/planx-new/actions/runs/10358321445
Two part bug:
__dirname is not definederror was being thrown when trying to generate zip folders for submissions (hence Uniform-related e2e failure) - we can now access this by usingfileURLToPathas outlined in this postpnpm test:The 'import.meta' meta-property is only allowed when the '--module' option is 'es2020', 'es2022', 'esnext', 'system', 'node16', or 'nodenext'- which is a bit strange because these options do indeed match our API'stsconfigts-jest-mock-import-metaManual testing notes:
__dirnameerror: https://api.editor.planx.dev/admin/session/be215bcf-1acf-4d76-893c-3c319a00966a/zip (connect to Warp to access, open this GET endpoint in your browser, expect it to trigger a download but instead throws error)