feat: Use shared Switch component instead of MUISwitch directly
#3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/standard-switch
branch
from
4d865ee
to
3975db7
Compare
DafyddLlyr
force-pushed
the
dp/standard-switch
branch
from
3975db7
to
b8e60cb
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
changed the title
Switch component instead of MUISwitch directly
DafyddLlyr
commented
Nov 11, 2024
Comment on lines
+107
to
+114
| formControlLabelProps={{ | ||
| sx: { | ||
| marginBottom: 0.5, | ||
| [`& .${formControlLabelClasses.label}`]: { | ||
| fontWeight: FONT_WEIGHT_BOLD, | ||
| textTransform: "capitalize", | ||
| fontSize: 19, | ||
| }, |
There was a problem hiding this comment.
Switches in these forms are visually different - the label is also really the title of the card.
We could make this a variant, or could attempt to standardise here, but this seemed the best way to handle this initially.
jessicamcinchak
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switchcomponent, with label, to be used across PlanX.eslintrule to enforce that the shared component should be imported