Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: feedback component unit tests #3937

Closed
wants to merge 48 commits into from
Closed

test: feedback component unit tests #3937

wants to merge 48 commits into from

Commits on Oct 28, 2024

  1. Clarify how-to doc

    @jamdelion
    jamdelion committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    918afc6 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Reorganise Feedback folder

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    576087e View commit details
    Browse the repository at this point in the history

  2. Use latest planx-core hash

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    abcc570 View commit details
    Browse the repository at this point in the history

  3. Use types.feedback

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9a12ba4 View commit details
    Browse the repository at this point in the history

  4. Add types.feedback to more places

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b559588 View commit details
    Browse the repository at this point in the history

  5. Fix import

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    20cba62 View commit details
    Browse the repository at this point in the history

  6. Add to preview node

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2e225b5 View commit details
    Browse the repository at this point in the history

  7. Add feedback to summaryList

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8ecfd4f View commit details
    Browse the repository at this point in the history

  8. Update doc

    @jamdelion
    jamdelion committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    01187ec View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add basic editor test

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    de19573 View commit details
    Browse the repository at this point in the history

  2. Improve editor modal with more fields - not wired up yet

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    96a9872 View commit details
    Browse the repository at this point in the history

  3. Add feature flag for dropdown menu

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    637fa91 View commit details
    Browse the repository at this point in the history

  4. Update props

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    40393bd View commit details
    Browse the repository at this point in the history

  5. Render richtextinputs ok with reactorhtml component

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7ff31e4 View commit details
    Browse the repository at this point in the history

  6. Use placeholders if no inputs given

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    70648bc View commit details
    Browse the repository at this point in the history

  7. Remove validation line

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c5ed74a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into jh/feedback-editor-side

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    26bc608 View commit details
    Browse the repository at this point in the history

  9. Fixes after merge conflict

    @jamdelion
    jamdelion committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    79e2377 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'main' into jh/follow-on-feedback-component

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d224f21 View commit details
    Browse the repository at this point in the history

  2. Make facebox text lowercase and improve storybook

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ae23fc7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into jh/follow-on-feedback-component

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9f39ac9 View commit details
    Browse the repository at this point in the history

  4. Reverse inappropriate linting

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    478a8cd View commit details
    Browse the repository at this point in the history

  5. Add moreInfo component propbs into public view and update doc

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a1d3e60 View commit details
    Browse the repository at this point in the history

  6. Use shared disclaimer component

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    50c0c58 View commit details
    Browse the repository at this point in the history

  7. Use defaultContent obj instead of placeholders

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    779d7be View commit details
    Browse the repository at this point in the history

  8. Use Input instead of richtextinput in public view

    @jamdelion
    jamdelion committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    015867c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. add aria label

    @jamdelion
    jamdelion committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    47d51bc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jh/follow-on-feedback-component

    @jamdelion
    jamdelion authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cc587ee View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into jh/follow-on-feedback-component

    @jamdelion
    jamdelion authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    38d134c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. On submit add to feedback table and breadcrumbs

    @jamdelion
    jamdelion committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0cb581e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jh/follow-on-feedback-component

    @jamdelion
    jamdelion authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9d4fbe9 View commit details
    Browse the repository at this point in the history

  3. Fix unit test

    @jamdelion
    jamdelion committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7e7eb05 View commit details
    Browse the repository at this point in the history

  4. Fix type issue

    @jamdelion
    jamdelion committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    adeb9da View commit details
    Browse the repository at this point in the history

  5. Add feedback log category for component feedback

    @jamdelion
    jamdelion committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d380647 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Undo changes to tables.yaml

    @jamdelion
    jamdelion committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a8380f9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jh/follow-on-feedback-component

    @jamdelion
    jamdelion committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0fd922b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. style: Feedback component style refinement (#3925)

    @ianjon3s
    ianjon3s authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fc55b80 View commit details
    Browse the repository at this point in the history

  2. Minor edits from PR comments - delete unneccessary code

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0aba609 View commit details
    Browse the repository at this point in the history

  3. Change feedback field to userComment

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    aa19903 View commit details
    Browse the repository at this point in the history

  4. Use capitlize type utility

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    72f3da8 View commit details
    Browse the repository at this point in the history

  5. Change feedback_score column to number

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    637f525 View commit details
    Browse the repository at this point in the history

  6. Add down.sql for add feedback_score column as int

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bb6f614 View commit details
    Browse the repository at this point in the history

  7. Fix disclaimer and default fallbacks

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    22fdc80 View commit details
    Browse the repository at this point in the history

  8. Remove fallback in disclaimer

    @jamdelion
    jamdelion committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bc4d4d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Initial tests and notes

    @jamdelion
    jamdelion committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    119dd0a View commit details
    Browse the repository at this point in the history

  2. Validate feedback required and show error messages

    @jamdelion
    jamdelion committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    63bd97e View commit details
    Browse the repository at this point in the history

  3. Refactor public tests to use describe.each

    @jamdelion
    jamdelion committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a7c17ce View commit details
    Browse the repository at this point in the history

  4. Add keyboard navigation test

    @jamdelion
    jamdelion committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5ea67fc View commit details
    Browse the repository at this point in the history