feat: can toggle feedback required and show validation errors #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
changed the title
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 12, 2024
| : number() | ||
| .integer() | ||
| .min(1, "Feedback score must be at least 1") | ||
| .max(5, "Feedback score cannot exceed 5"), |
There was a problem hiding this comment.
nit: while this validation schema is totally correct, are min & max actually useful user-facing errors here since the user is interacting with a set of emoji expressions rather than inputing a number score? Basically I think I'd vote .required() or undefined is plenty here?
Also perhaps "Please rate your experience" would better align to default label text rather than "Please provide a feedback score" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
public.test.tsxinto two test files (one for accessibility, one for submission tests)