feat: Allow SelectMultiple to have either a label or placeholder prop
#3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
SelectMultiple to have either a label or placeholder prop
DafyddLlyr
commented
Nov 14, 2024
| return ( | ||
| <FormControl sx={{ display: "flex", flexDirection: "column" }}> | ||
| <StyledAutocomplete<T, true, true, false, "div"> | ||
| sx={{ mt: props.label ? 2 : 0 }} |
There was a problem hiding this comment.
Handling this within the styled component is surprisingly complex from a type POV! Managing it here feels like a sensible compromise 👍
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate implementation of #3927
Visually the same, but relies on more simplified and strict type checking in the component to allow either
labelorplaceholderto be passed as props.Screen.Recording.2024-11-14.at.10.37.54.mov