Fix leading zeros #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that leading zeros are allowed if there are non-numeric characters in a part. Previously, the code rejected a version such as `1.0.0-alpha.0a` but now accepts it. It also now better enforces the no-leading-zeros rule, where prviously `1.0.0-02799` was allowed and now is not. Resolves #45.
Already there, just testing.
theory
added a commit
that referenced
this pull request
May 14, 2020
Add a test script with the official SemVer project test corpus, and fix the issues found. This results in the exclusion of previously-accepted semvers, including: * Metadata parts with additional plus signs, e.g., `9.8.7+meta+meta` * Metadata or prerelease parts that start with a dot, e.g., `1.1.2+.123` or `1.1.2-.123`. As with #49, we need to decide how to handle existing stored instances of such previously- allowed values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to discussion on #45, properly prevent leading
0s in prerelease parts only when there are no alphanumeric characters. Also fix an issue where it would ignore the first leading0in a prerelease no matter what else was in the part.