Fix broken parsing of emphasized text ending with a '0' character (#81)

The issue was caused by non-strict tests, where a "0" string was considered falsy.
thephpleague · Mar 5, 2015 · 3ba7a45 · 3ba7a45
1 parent 7b428e9
commit 3ba7a45
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file.
 Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) principles.
 
 ## [Unreleased][unreleased]
+### Fixed
+ - Fixed broken parsing of emphasized text ending with a '0' character (#81)
 
 ## [0.7.1] - 2015-03-01
 ### Added

diff --git a/src/Inline/Parser/EmphasisParser.php b/src/Inline/Parser/EmphasisParser.php
@@ -46,15 +46,21 @@ public function parse(ContextInterface $context, InlineParserContext $inlineCont
         $numDelims = 0;
 
         $cursor = $inlineContext->getCursor();
-        $charBefore = $cursor->peek(-1) ?: "\n";
+        $charBefore = $cursor->peek(-1);
+        if ($charBefore === null) {
+            $charBefore = "\n";
+        }
 
         while ($cursor->peek($numDelims) === $character) {
             ++$numDelims;
         }
 
         $cursor->advanceBy($numDelims);
 
-        $charAfter = $cursor->getCharacter() ?: "\n";
+        $charAfter = $cursor->getCharacter();
+        if ($charAfter === null) {
+            $charAfter = "\n";
+        }
 
         $leftFlanking = $numDelims > 0 && !preg_match('/\pZ|\s/u', $charAfter) &&
             !(preg_match(RegexHelper::REGEX_PUNCTUATION, $charAfter) &&