Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute to remove 8.1 deprecation notice #785

Merged
merged 2 commits into from
Jan 13, 2022
Merged

attribute to remove 8.1 deprecation notice #785

merged 2 commits into from
Jan 13, 2022

Conversation

edalzell
Copy link
Contributor

I'm using a CMS that uses Commonmark 1.6, and updating to 2.x is a large endeavor for them at the moment. However this package (1.6) still works great on PHP 8.1, except for one deprecation notice related to the getIterator method.

Hoping you'd be willing to merge this into the existing 1.6 branch so we can stop these deprecation errors from flooding our logs.

No functionality added/changed, only an attribute added, which is ignored in PHP < 8.

@edalzell
Copy link
Contributor Author

I don't understand the failing PHPStan tests, but I didn't do anything around that code so perhaps it's unrelated?

Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution! I'll get this merged, tagged, and released shortly.

I've been planning to end support for v1.6 at the end of this month so your PR is very timely :)

@colinodell colinodell merged commit 2fe060c into thephpleague:1.6 Jan 13, 2022
@colinodell
Copy link
Member

Version 1.6.7 has been released with this fix. Thanks again!

@edalzell edalzell deleted the support-81 branch January 13, 2022 17:20
@edalzell
Copy link
Contributor Author

Amazing, thanks for the quick turn around, us Statamic folks (the CMS) really appreciate it...now we can fully support PHP 8.1.

@colinodell
Copy link
Member

I don't understand the failing PHPStan tests, but I didn't do anything around that code so perhaps it's unrelated?

Yeah, that was unrelated. We don't lock to a specific version of PHPStan so sometimes previously-undetected issues crop up when PHPStan adds support for detecting them. I added a separate commit to fix those just prior to releasing :)

Amazing, thanks for the quick turn around, us Statamic folks (the CMS) really appreciate it...now we can fully support PHP 8.1.

That's awesome, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants