Improve JSONConverter codebase

thephpleague · Sep 19, 2024 · c982bcc · c982bcc
1 parent 69caebb
commit c982bcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/JsonConverter.php b/src/JsonConverter.php
@@ -141,7 +141,7 @@ public function indentSize(int $indentSize): self
     }
 
     /**
-     * Set a callback to be used on each item before json encode.
+     * Set a callback to format each item before json encode.
      */
     public function formatter(?Closure $formatter): self
     {

diff --git a/src/JsonConverterTest.php b/src/JsonConverterTest.php
@@ -108,7 +108,7 @@ public function it_returns_a_null_object_if_the_collection_is_empty(): void
     public function it_can_manipulate_the_record_prior_to_json_encode(): void
     {
         $converter = JsonConverter::create()
-            ->formatter(fn (array $value) => array_map(strtoupper(...), $value));
+            ->formatter(fn (array $value, int|string $offset): array => array_map(strtoupper(...), $value));
 
         self::assertSame('[{"foo":"BAR"}]', $converter->encode([['foo' => 'bar']]));
     }