Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix Spl Flags #130

Merged
merged 1 commit into from
Oct 21, 2015
Merged

Bug Fix Spl Flags #130

merged 1 commit into from
Oct 21, 2015

Conversation

nyamsprod
Copy link
Member

  • default flag is now SplFileObject::READ_AHEAD|SplFileObject::SKIP_EMPTY
  • AbstractCsv::__toString is also bug fixed

@nyamsprod
Bug Fix Spl Flags
6f743bf 
- default flag is now SplFileObject::READ_AHEAD|SplFileObject::SKIP_EMPTY
- AbstractCsv::__toString is also bug fixed
@nyamsprod
Copy link
Member Author

This PR fixes two bugs related to SplFileObject flags used in the library

  • The default flags are now SplFileObject::READ_AHEAD|SplFileObject::SKIP_EMPTY. So that using foreach will return the expected data even when multiple lines are presents in CSV fields
  • the __toString method needs to normalize the flag usage to output correclty the file. Flags were badly applied which led to missing rows in the output

nyamsprod added a commit that referenced this pull request Oct 21, 2015
@nyamsprod
Merge pull request #130 from thephpleague/bugfix/default-options
924cbde 
Bug Fix Spl Flags
@nyamsprod nyamsprod merged commit 924cbde into master Oct 21, 2015
@nyamsprod nyamsprod deleted the bugfix/default-options branch October 21, 2015 13:46
nyamsprod added a commit that referenced this pull request Oct 29, 2015
@nyamsprod
Improving code quality
46eedd3 
- remove the need for the $newline argument in createFromString #132 #130
- improve integer filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nyamsprod