Bug fix #213 and #208 #215
Conversation
nyamsprod
commented
Feb 22, 2017
nyamsprod
commented
- Remove the @deprecate message from the Reader class Deprecation of League\Csv\Reader::fetch #208
- Bug fix internal Reader::getRow when used with a StreamIterator fetchAssoc() fails with freshly created Reader #213
nyamsprod
force-pushed
the
bugfix-v8/issues-208-213
branch
from
d01d0b5
to
8992405
Compare
| @@ -156,18 +156,17 @@ public function setFlags($flags) | |||
| * @param array $fields | |||
| * @param string $delimiter | |||
| * @param string $enclosure | |||
| * @param string $escape | |||
There was a problem hiding this comment.
You removed the $escape type hint, but the param is still available in the method.
There was a problem hiding this comment.
yep typo error from my part.. I'll correct that
| * | ||
| * @return int | ||
| */ | ||
| public function fputcsv(array $fields, $delimiter = null, $enclosure = null, $escape = null) | ||
| public function fputcsv(array $fields, $delimiter = ',', $enclosure = '"', $escape = '\\') |
There was a problem hiding this comment.
This changes the public interface and should not be part of a bugfix.
There was a problem hiding this comment.
it should be part of bugfix because it aligns the StreamIterator to how SplFileObject and fputcsv works. StreamIterator must be align to SplFileObject and it did no align.
There was a problem hiding this comment.
StreamIterator is marked as @internal so anyone using it in public API exposes himself to harm.
| } | ||
|
|
||
| return str_getcsv($line, $this->delimiter, $this->enclosure, $this->escape); | ||
| return $row; |
There was a problem hiding this comment.
The expected return value for this method is an array, and now appears to be a string.
There was a problem hiding this comment.
no $row is always an array otherwise an exception is triggered
