Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EscapeFormulaInjection formatter #269

Merged
merged 3 commits into from
Oct 17, 2017
Merged

Conversation

nyamsprod
Copy link
Member

view #268

@nyamsprod
Copy link
Member Author

@klaude here's a POC which works so it was simple to add But I'm still skeptical in its usefulness and/or binding it to the package

@klaude klaude mentioned this pull request Oct 16, 2017
@klaude
Copy link

klaude commented Oct 16, 2017

That looks good to me. I think the only difference between this and what I was envisioning was a constructor argument to say which columns to escape, but this suits my purposes at work just fine.

@nyamsprod nyamsprod merged commit 04bb837 into master Oct 17, 2017
@nyamsprod nyamsprod deleted the feature/formula-injection branch October 17, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants