fix CI for PHP 8.0 #405
Merged
fix CI for PHP 8.0 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IonBazan thanks for the PR will review and merge it as soon as possible 🎉 and I will credit you for making the package available for PHP8 in the changelog 👍 |
|
@nyamsprod Thank you for merging. Can you also create a new release to allow users to migrate to PHP 8.0? |
|
@IonBazan it's in my today's to-do list don't worry 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404 -
iterator_to_arrayis not marked as pure anymore: JetBrains/phpstorm-stubs#969Checks are still run on PHP 7.4 because PHP 8.0 introduces
falsereturn type forcreateElementand other DOM-related methods - I will try to provide a fix in a separate PR soon.