Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain file visibility when copying in LocalAdapter #1730

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Retain file visibility when copying in LocalAdapter #1730

merged 2 commits into from
Nov 18, 2023

Conversation

jnoordsij
Copy link
Contributor

This is a follow-up to both #1723 and #1721, that changes the visibility retainment behavior of LocalAdapter in the following way:

  • retain the visibility of the copied file by default, matching behavior of various other adapters (e.g. the AWS and FTP adapters)
  • allow passing a config key to disable this behavior

@frankdejonge frankdejonge merged commit 3072f52 into thephpleague:3.x Nov 18, 2023
5 checks passed
@frankdejonge
Copy link
Member

Much appreciated!

@jnoordsij jnoordsij deleted the local-adapter-retain-visibility branch November 18, 2023 14:00
This was referenced Nov 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnoordsij @frankdejonge