Make autolinking configurable #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
colinodell
requested changes
Jun 30, 2020
tests/HtmlConverterTest.php
Outdated
| $result = $markdown('<a href="https://www.google.com">Google</a>'); | ||
| $this->assertEquals('[Google](https://www.google.com)', $result); | ||
| $result = $markdown('<a href="google.com">google.com</a>'); | ||
| $this->assertEquals('[google.com](google.com)', $result); |
There was a problem hiding this comment.
Would you mind changing this to use the $this->html_give_markdown() helper method instead for consistency?
There was a problem hiding this comment.
Ah! I totally missed the fact that this method also accepts options. There are so few test cases using it that at a first glance I missed that completely.
colinodell
approved these changes
Jul 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request #187
use_autolinksaddedfalse, the short link syntax<url>will not be used