Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Entities Interfaces out #504

Closed
juliangut opened this issue Mar 29, 2016 · 1 comment
Closed

Move Entities Interfaces out #504

juliangut opened this issue Mar 29, 2016 · 1 comment
Milestone
v5.0.0-RC2

Comments

@juliangut
Copy link
Contributor

In all cases but Entities interfaces are at the same level as implementations

  • GrantTypeInterface and its implementations
  • ResponseTypeInterface and its implementatios and
  • RendererInterface and template renderer implementations

But in the case for Entities a new NS is created to hold interfaces. I'd suggest to move them up one level directly under Entities directory
@alexbilbie alexbilbie added this to the v5.0.0-RC2 milestone Apr 8, 2016
@alexbilbie alexbilbie added the V5 label Apr 8, 2016
alexbilbie added a commit that referenced this issue Apr 9, 2016
@alexbilbie
Moved entity interfaces into parent folder. Fixes #504
4eee48c
@alexbilbie
Copy link
Contributor

Fixed by 4eee48c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0.0-RC2
Development

No branches or pull requests
2 participants
@alexbilbie @juliangut