Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant for event name instead of explicit string #563

Closed
wants to merge 1 commit into from
Closed

Use constant for event name instead of explicit string #563

wants to merge 1 commit into from

Conversation

ismailbaskin
Copy link
Contributor

No description provided.

@alexbilbie
Copy link
Contributor

Thanks for your PR.

I'm wondering if these constants could be added to the RequestEvent class instead?

@ismailbaskin
Copy link
Contributor Author

It is only convention. Do you want to do I do?

@alexbilbie
Copy link
Contributor

I think having the constants in the RequestEvent class is better; no need to introduce a brand new class into the library

alexbilbie added a commit that referenced this pull request May 4, 2016
@alexbilbie
Use constant for event name instead of explicit string. Fixes #563
cdf43e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailbaskin @alexbilbie