Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #34: Testing 'Internal Server Error (500)' #35

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

Starli0n
Copy link
Contributor

@Starli0n Starli0n commented Sep 2, 2016

PHPUnit Ok!

PHPUnit 5.5.2 by Sebastian Bergmann and contributors.

..................                                                18 / 18 (100%)

Time: 266 ms, Memory: 10.00MB

OK (18 tests, 34 assertions)

@Starli0n
Copy link
Contributor Author

Starli0n commented Sep 2, 2016

Sorry I was too hasty and I forgot to add some unit tests.

I will do it next week. Anyway the Travis tests failed.

@Starli0n Starli0n force-pushed the master branch 4 times, most recently from b4beac1 to 33ea651 Compare September 5, 2016 12:33
@Starli0n
Copy link
Contributor Author

Starli0n commented Sep 5, 2016

I had to change the lowest version of Slim (~3.1) as the process() method did not exist before.

@Starli0n
Copy link
Contributor Author

Is it Ok for you now?

@craig-davis
Copy link
Contributor

@Starli0n I am very sorry that this was not merged in a timely manner. We need to give this project some love and attention. I'm going to add you as a contributor as well.

@craig-davis craig-davis merged commit 8558755 into there4:master Apr 25, 2017
@Starli0n
Copy link
Contributor Author

Thank you for adding me as contributor.
I really appreciate it :-)

@craig-davis
Copy link
Contributor

@Starli0n Thank you for contributing!

Next on my list it to get this upgraded to phpunit 6. I've been short on time lately, but it's a goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants