Add named parameter

thesandboxgame · Sep 16, 2024 · 28ceac9 · 28ceac9 · github-actions · Sep 16, 2024
1 parent 2cd712d
commit 28ceac9
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/packages/marketplace/contracts/TransferManager.sol b/packages/marketplace/contracts/TransferManager.sol
@@ -297,16 +297,17 @@ abstract contract TransferManager is Initializable, ITransferManager {
         uint256 feePrimary,
         uint256 feeSecondary,
         LibAsset.Bundle memory bundle
-    ) internal returns (uint256) {
+    ) internal returns (uint256 remainingValue) {
+        remainingValue = remainder;
         for (uint256 i; i < bundle.bundledERC721.length; i++) {
             address token = bundle.bundledERC721[i].erc721Address;
             uint256 idLength = bundle.bundledERC721[i].ids.length;
             for (uint256 j; j < idLength; j++) {
-                remainder = _processSingleAsset(
+                remainingValue = _processSingleAsset(
                     paymentSide,
                     nftSide,
                     nftSideRecipient,
-                    remainder,
+                    remainingValue,
                     feePrimary,
                     feeSecondary,
                     token,
@@ -315,7 +316,7 @@ abstract contract TransferManager is Initializable, ITransferManager {
                 );
             }
         }
-        return remainder;
+        return remainingValue;
     }
 
     function _processERC1155Bundles(
@@ -326,19 +327,20 @@ abstract contract TransferManager is Initializable, ITransferManager {
         uint256 feePrimary,
         uint256 feeSecondary,
         LibAsset.Bundle memory bundle
-    ) internal returns (uint256) {
+    ) internal returns (uint256 remainingValue) {
+        remainingValue = remainder;
         for (uint256 i; i < bundle.bundledERC1155.length; i++) {
             address token = bundle.bundledERC1155[i].erc1155Address;
             uint256 idLength = bundle.bundledERC1155[i].ids.length;
             require(idLength == bundle.bundledERC1155[i].supplies.length, "ERC1155 array error");
 
             for (uint256 j; j < idLength; j++) {
                 for (uint256 k = 0; k < nftSide.asset.value; k++) {
-                    remainder = _processSingleAsset(
+                    remainingValue = _processSingleAsset(
                         paymentSide,
                         nftSide,
                         nftSideRecipient,
-                        remainder,
+                        remainingValue,
                         feePrimary,
                         feeSecondary,
                         token,
@@ -348,7 +350,7 @@ abstract contract TransferManager is Initializable, ITransferManager {
                 }
             }
         }
-        return remainder;
+        return remainingValue;
     }
 
     function _processQuadBundles(