Skip to content

Commit

Permalink
fixed: removed redundant code
Browse files Browse the repository at this point in the history
  • Loading branch information
capedcrusader21 committed Sep 16, 2024
1 parent 317980f commit b10622c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions packages/marketplace/contracts/ExchangeCore.sol
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
pragma solidity 0.8.23;

import {Initializable} from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
import {Address} from "@openzeppelin/contracts/utils/Address.sol";
import {ERC165Checker} from "@openzeppelin/contracts/utils/introspection/ERC165Checker.sol";
import {LibAsset} from "./libraries/LibAsset.sol";
import {LibOrder} from "./libraries/LibOrder.sol";
Expand All @@ -15,9 +14,6 @@ import {IOrderValidator} from "./interfaces/IOrderValidator.sol";
/// @notice Contains the main functions for the marketplace.
/// @dev This is an abstract contract that requires implementation.
abstract contract ExchangeCore is Initializable, ITransferManager {
using Address for address;
using ERC165Checker for address;

/// @dev Stores left and right orders that match each other.
/// Left and right are symmetrical except for fees that are taken from the left side first.
struct ExchangeMatch {
Expand Down
2 changes: 0 additions & 2 deletions packages/marketplace/contracts/TransferManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,6 @@ abstract contract TransferManager is Initializable, ITransferManager {
}
}
if (quadsLength > 0) {
require(quadsLength == bundle.quads.ys.length, "quad error");
require(quadsLength == bundle.quads.sizes.length, "quad size error");
landContract.batchTransferQuad(
from,
to,
Expand Down

1 comment on commit b10622c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

98.21%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/marketplace/contracts
   Exchange.sol94.52%93.33%94.44%96%127, 195, 73
   ExchangeCore.sol98.84%96.67%100%100%81
   OrderValidator.sol98.44%96.15%100%100%36
   RoyaltiesRegistry.sol96.32%88.89%100%98.78%194, 216–217, 263, 65
   TransferManager.sol96.04%87.50%100%99.41%163, 225, 247, 333, 393, 430, 581, 586, 597, 619, 93
   Whitelist.sol75.81%60%85.71%82.14%105, 109–110, 123, 126, 142–143, 55, 67, 67–68, 72, 77
packages/marketplace/contracts/interfaces
   IOrderValidator.sol100%100%100%100%
   IRoyaltiesProvider.sol100%100%100%100%
   ITransferManager.sol100%100%100%100%
   IWhitelist.sol100%100%100%100%
packages/marketplace/contracts/libraries
   LibAsset.sol100%100%100%100%
   LibMath.sol100%100%100%100%
   LibOrder.sol100%100%100%100%

Please sign in to comment.