Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-01 Orders With Multiple ERC-721-less Bundles May Not Be Fully Considered #1589

Open
wants to merge 1 commit into
base: feat/marketplace-bundle-type
Choose a base branch
from
Open

H-01 Orders With Multiple ERC-721-less Bundles May Not Be Fully Considered #1589

wants to merge 1 commit into from

Conversation

capedcrusader21
Copy link
Contributor

@capedcrusader21 capedcrusader21 commented Sep 11, 2024 •
edited
Loading

Description

  • removed BundledERC20 from Bundle and Exchange doc.

  • Changes when Exchanging multiple bundles with only ERC1155s

  1. logic to calculate total bundle price
  2. NFT and Royalty transfer
  • TODO : lint fix ( in M-02 fix)
Screenshot 2024-09-11 at 4 24 10 PM Screenshot 2024-09-11 at 4 24 18 PM

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Sep 11, 2024 •
edited
Loading

H-01 Orders With Multiple ERC-721-less Bundles May Not Be Fully Considered

Generated at commit: e1a4a275c1034959187ee5d0c5330df4dfa0321e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
1
0
7
30
40

For more details view the full report in OpenZeppelin Code Inspector

wojciech-turek
wojciech-turek requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@wojciech-turek wojciech-turek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the documentation to remove ERC20 reference.
I found it in packages/marketplace/docs/Exchange.md

packages/marketplace/contracts/TransferManager.sol Show resolved Hide resolved
packages/marketplace/contracts/TransferManager.sol Show resolved Hide resolved
packages/marketplace/contracts/TransferManager.sol Show resolved Hide resolved
packages/marketplace/contracts/libraries/LibAsset.sol Outdated Show resolved Hide resolved
@capedcrusader21 capedcrusader21 force-pushed the marketplace-bundle/H-01-orders-with-multiple-ERC721-less-bundles branch from 7cdc4e7 to e1a4a27 Compare September 11, 2024 14:57
@capedcrusader21 capedcrusader21 marked this pull request as ready for review September 11, 2024 14:58
@capedcrusader21 capedcrusader21 requested a review from a team as a code owner September 11, 2024 14:58
@capedcrusader21 capedcrusader21 requested review from wojciech-turek and adjisb and removed request for a team September 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-turek wojciech-turek wojciech-turek approved these changes

@adjisb adjisb Awaiting requested review from adjisb adjisb is a code owner automatically assigned from thesandboxgame/blockchain-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capedcrusader21 @wojciech-turek