forked from ProjectEvergreen/greenwood-demo-adapter-vercel
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo/restore products page and upgrade to Lit v3 #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thescientist13
changed the title
upgrade to lit v3
enhancement/issue 6 upgrade to lit v3
Nov 21, 2023
So interestingly, if I add the hydration support script from Lit, the double products page render goes away but.... <script type="module" src="/node_modules/@lit-labs/ssr-client/lit-element-hydrate-support.js"></script> The interactivity breaks lolsad, The |
thescientist13
changed the title
enhancement/issue 6 upgrade to lit v3
enhancement/restore products page and upgrade to Lit v3
Dec 1, 2023
thescientist13
changed the title
enhancement/restore products page and upgrade to Lit v3
demo/restore products page and upgrade to Lit v3
Jan 27, 2024
thescientist13
force-pushed
the
enhancement/issue-6-upgrade-lit3
branch
from
January 28, 2024 17:34
c0799a4
to
8e3bb01
Compare
Merged
16 tasks
6 tasks
1 task
Will keep this as a reference and will drive through the polished through #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3 / #6
Changes
render
renderToString
to use newcollectResult
SSR APITODO
dev
serve
greenwood serve
, ex. load the API routes a couple times (seems fine when run on serverless) - feature/discussion 1117 Isolation Mode (v1) ProjectEvergreen/greenwood#1206Upstream Needs Tracking / Notes
ProjectEvergreen/greenwood#1197
Greenwood CLI
type="module-shim"
globalThis
for state?) ProjectEvergreen/greenwood#880 (will WCC need hydration support?)Lit Renderer
getBody
/getPage
APIexport const hydration = true
export const function loader() => { /* ... */ }
Thoughts / Questions