Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove observedAttributes setters #3

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

remove observedAttributes setters #3

wants to merge 2 commits into from

Conversation

thescientist13
Copy link
Owner

Related Issue

relates to #2 / ProjectEvergreen/wcc#87

Summary of Changes

  1. Remove observedAttributes from Badge and TodoListItem components

Note: Couldn't get overrides working with GitHub repos, so will have to manually copy / paste from the upstream PR 🤷‍♂️

@thescientist13 thescientist13 added enhancement New feature or request needs upstream labels Sep 2, 2022
@thescientist13 thescientist13 self-assigned this Sep 2, 2022
@vercel
Copy link

vercel bot commented Sep 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
todo-app ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 9:56PM (UTC)

@thescientist13 thescientist13 mentioned this pull request Sep 2, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
enhancement New feature or request needs upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13