Update UI of Beehive Component #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Let's standardize the styles for the card component to make possible editing easier.
kpyszkowski
reviewed
Nov 12, 2024
New version of asset weights more - 22 KB vs 37 KB so let's back to the previous one.
kpyszkowski
previously approved these changes
Nov 13, 2024
This PR standardizes our styles for the `Card` component. What has been
done:
- In many places we have set `padding={0}` for the `CardBody`. Let's set
a single common padding for the Card component.
- Updated header styles for the cards.
- Removed the border for the `Card` component and the unneeded
`elevated` variant.
- Removed unneeded props that are already defined in the card theme.
⚠️ Important notice ⚠️
Many things probably still need to be improved, but I believe this PR
cleans our code a bit. Let's make the next fixes and integrate with
styleguide in the next steps.
kpyszkowski
approved these changes
Nov 13, 2024
kpyszkowski
requested review from
r-czajkowski
and removed request for
r-czajkowski
r-czajkowski
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #801
This PR updates UI of Beehive Component to be consistent with the designs. What has been done:
InfoTooltipcomponent to be consistent with the designBeehiveCardUpdating the Card component is more complicated. Let's do the update in a separate PR to make sure the changes don't break anything
UI
