-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep-test: ETH faucet #174
Commits on Nov 23, 2019
-
Include web3 in Heimdall packages
In order for the freshly minted keep-test-eth-faucet Heimdall script to run we need web3 commands available. Here we install that package.
Sloan Thompson committedNov 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 4222fa9 - Browse repository at this point
Copy the full SHA 4222fa9View commit details -
First pass, basic keep-test faucet
We run a handful of internal ethereum chains, they're a pain in the ass to fund accounts on. You have to use the geth console, or geth CLI to transfer eth. Our keep-test environment has a public transaction node. This means we can take advantage of Heimdall to fund accounts on this chain, instead of having to use the aforementioned methods. Here we provide a very basic Heimdall command that funds a passed account with 10 eth.
Sloan Thompson committedNov 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 3241362 - Browse repository at this point
Copy the full SHA 3241362View commit details
Commits on Nov 25, 2019
-
Sloan Thompson committed
Nov 25, 2019 Configuration menu - View commit details
-
Copy full SHA for 36d6d89 - Browse repository at this point
Copy the full SHA 36d6d89View commit details -
To semicolon or not to semicolon
Can go either way really...but we need to whole-ass whichever way that is.
Sloan Thompson committedNov 25, 2019 Configuration menu - View commit details
-
Copy full SHA for 6279ea1 - Browse repository at this point
Copy the full SHA 6279ea1View commit details -
Sloan Thompson committed
Nov 25, 2019 Configuration menu - View commit details
-
Copy full SHA for 788915e - Browse repository at this point
Copy the full SHA 788915eView commit details
Commits on Dec 3, 2019
-
Rather than peg the script to an environment we're making the naming generic, with a note that the script only works for keep-test at the moment. This is to set the intention that we should be able to use this script for multiple environments, it just needs to be extended.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 0762f53 - Browse repository at this point
Copy the full SHA 0762f53View commit details -
Standardize variable expansion
We were using mixed mode variable expansion in strings, I updated the one outlier to match the rest of the script. Also added a note that this script only works with keep-test at the moment.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 3bf25da - Browse repository at this point
Copy the full SHA 3bf25daView commit details -
Eventually we'll be able to pass an environment as an argument to this command. For now we shorten and make the faucet invocation command generic, as it should be.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 23575ca - Browse repository at this point
Copy the full SHA 23575caView commit details -
Remove async from from function(robot)
Frankly I'm not sure why we can do this. In previous experience you had to use async/await all the way up the path, else you would run into runtime errors regarding using await in a non-async function.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 025147d - Browse repository at this point
Copy the full SHA 025147dView commit details -
Removed purse account from funding log
It's a bit unnecessary from the perspective of the person being funded. They don't care where the ETH comes from, and we as operators know who the purse is.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for e656363 - Browse repository at this point
Copy the full SHA e656363View commit details -
In an effor to enforce ordering we wrap the msg.send calls for await results in then. This seems to work, however it produces a new scenario where then then log is returned before the msg.send message that should fire BEFORE the await. Need to look closer.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for f067c04 - Browse repository at this point
Copy the full SHA f067c04View commit details -
Return msg.send in catch blocks
we need to exit on catch, adding a return so that if we catch we don't try to continue the script.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 3d51ab8 - Browse repository at this point
Copy the full SHA 3d51ab8View commit details -
The "account" in this case is the purse. We should clarify that this password is for the purse, not just an eth account.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for b3e4238 - Browse repository at this point
Copy the full SHA b3e4238View commit details -
tl;dr here is that we think the ordering issues on Flowdock are due to the fact that the unlocked and funding msg.sends are firing at about the same time, and that Flowdock doesn't guarantee ordering in that case. We're just going to go ahead and remove the unlocked log, as this falls over if the accounnt isn't unlocked anyway (and we have logging for that).
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 0f4de6d - Browse repository at this point
Copy the full SHA 0f4de6dView commit details -
Needed to update the usage comment after shortening the command. This also includes changes made by prettier.
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 7abcdc6 - Browse repository at this point
Copy the full SHA 7abcdc6View commit details -
Sloan Thompson committed
Dec 3, 2019 1Configuration menu - View commit details
-
Copy full SHA for f83eff4 - Browse repository at this point
Copy the full SHA f83eff4View commit details -
Last stab then I'm digging, does this one have all the things
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for c1ff9aa - Browse repository at this point
Copy the full SHA c1ff9aaView commit details -
Adding python dependencies due to web3
Sloan Thompson committedDec 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 8037253 - Browse repository at this point
Copy the full SHA 8037253View commit details