Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep-test: ETH faucet #174

Merged
merged 18 commits into from
Dec 4, 2019
Merged

keep-test: ETH faucet #174

merged 18 commits into from
Dec 4, 2019

Commits on Nov 23, 2019

  1. Include web3 in Heimdall packages

    In order for the freshly minted keep-test-eth-faucet Heimdall script to
    run we need web3 commands available.  Here we install that package.
    Sloan Thompson committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    4222fa9 View commit details
    Browse the repository at this point in the history
  2. First pass, basic keep-test faucet

    We run a handful of internal ethereum chains, they're a pain in the ass
    to fund accounts on.  You have to use the geth console, or geth CLI to
    transfer eth.  Our keep-test environment has a public transaction node.
    This means we can take advantage of Heimdall to fund accounts on this
    chain, instead of having to use the aforementioned methods.  Here we
    provide a very basic Heimdall command that funds a passed account with
    10 eth.
    Sloan Thompson committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    3241362 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. ily

    Sloan Thompson committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    36d6d89 View commit details
    Browse the repository at this point in the history
  2. To semicolon or not to semicolon

    Can go either way really...but we need to whole-ass whichever way that
    is.
    Sloan Thompson committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    6279ea1 View commit details
    Browse the repository at this point in the history
  3. Some space preese

    Sloan Thompson committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    788915e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Rename faucet script

    Rather than peg the script to an environment we're making the naming
    generic, with a note that the script only works for keep-test at the
    moment.  This is to set the intention that we should be able to use this
    script for multiple environments, it just needs to be extended.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    0762f53 View commit details
    Browse the repository at this point in the history
  2. Standardize variable expansion

    We were using mixed mode variable expansion in strings, I updated the
    one outlier to match the rest of the script.  Also added a note that
    this script only works with keep-test at the moment.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3bf25da View commit details
    Browse the repository at this point in the history
  3. Shortened faucet command

    Eventually we'll be able to pass an environment as an argument to this
    command.  For now we shorten and make the faucet invocation command
    generic, as it should be.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    23575ca View commit details
    Browse the repository at this point in the history
  4. Remove async from from function(robot)

    Frankly I'm not sure why we can do this.  In previous experience you had
    to use async/await all the way up the path, else you would run into
    runtime errors regarding using await in a non-async function.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    025147d View commit details
    Browse the repository at this point in the history
  5. Removed purse account from funding log

    It's a bit unnecessary from the perspective of the person being funded.
    They don't care where the ETH comes from, and we as operators know who
    the purse is.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    e656363 View commit details
    Browse the repository at this point in the history
  6. Wrap success logs in then()

    In an effor to enforce ordering we wrap the msg.send calls for await
    results in then.  This seems to work, however it produces a new scenario
    where then then log is returned before the msg.send message that should
    fire BEFORE the await.  Need to look closer.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    f067c04 View commit details
    Browse the repository at this point in the history
  7. Return msg.send in catch blocks

    we need to exit on catch, adding a return so that if we catch we don't
    try to continue the script.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3d51ab8 View commit details
    Browse the repository at this point in the history
  8. Rename ethAccountPassword

    The "account" in this case is the purse.  We should clarify that this
    password is for the purse, not just an eth account.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    b3e4238 View commit details
    Browse the repository at this point in the history
  9. Remove funded log

    tl;dr here is that we think the ordering issues on Flowdock are due to
    the fact that the unlocked and funding msg.sends are firing at about
    the same time, and that Flowdock doesn't guarantee ordering in that
    case.  We're just going to go ahead and remove the unlocked log, as this
    falls over if the accounnt isn't unlocked anyway (and we have logging
    for that).
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    0f4de6d View commit details
    Browse the repository at this point in the history
  10. Update usage comment

    Needed to update the usage comment after shortening the command.  This
    also includes changes made by prettier.
    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    7abcdc6 View commit details
    Browse the repository at this point in the history
  11. Stab stab

    Sloan Thompson committed Dec 3, 2019
    1 Configuration menu
    Copy the full SHA
    f83eff4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c1ff9aa View commit details
    Browse the repository at this point in the history
  13. Adding python dependencies due to web3

    Sloan Thompson committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    8037253 View commit details
    Browse the repository at this point in the history