Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for special characters #60

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

pjona
Copy link
Contributor

@pjona pjona commented Aug 8, 2017

Without this changes the new test that I added fail. So for example, you have in your .env password with special characters:

PASSWORD="}=&~{,(\5%{&;"

But using package it return: }=&~{,(%{&; (Missing \5)

@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage remained the same at 82.418% when pulling fa66e0b on pjona:special_characters into 77dc37d on theskumar:master.

@pjona
Copy link
Contributor Author

pjona commented Aug 8, 2017

I checked also PHP version of dotenv idea (https://github.com/vlucas/phpdotenv) and they handle it correctly.

@theskumar
Copy link
Owner

Thanks @pjona for the pull-request, i'll test and merge it soon!

@theskumar theskumar merged commit b7c6d1b into theskumar:master Aug 9, 2017
@theskumar
Copy link
Owner

Thanks a lot for contributing. This will be available in next release.

@theskumar
Copy link
Owner

theskumar commented Aug 9, 2017

python-dotenv==0.6.5 released. 🎉

@alanjds
Copy link
Contributor

alanjds commented Jan 15, 2018

People around me got some trouble w/ accents on right side of the =. Got working after reversing this patch.

What am I doing wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants