Open dotenv_path with UTF-8 encoding #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like tests are failing, can you look into it. |
|
Ok, I'll look into it and submit again. Thank you! |
|
@theskumar I fixed my code. Thank you! |
|
Is #60 (comment) related with this PR? |
|
Obviously not appropriate place to discuss this, but why this still hasn't been merged? |
theskumar
force-pushed
the
master
branch
2 times, most recently
from
d541b6c
to
fe35be1
Compare
|
We’re hitting this in pypa/pipenv#1963 as well. Either the file should always be decoded with UTF-8, or there should be an additional argument in |
theskumar
force-pushed
the
master
branch
2 times, most recently
from
f628767
to
f9863d3
Compare
|
This will be superseded by #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #74.
I think it is better to specify the encoding when opening the .env file.