Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement permessage-deflate extension #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meetmangukiya
Copy link

@meetmangukiya meetmangukiya commented Jul 3, 2019

Might not be the best implementation..

  1. I have processed only Binary, Text and Continuation frames in incoming frames
  2. Processed all the outgoing frames

Using websocket-extensions is gonna make it easier to hook any extension in here!

I have tested it against a permessage-deflate server.

@rgillan
Copy link

rgillan commented Nov 23, 2023

I would want to see this load tested (very high load like 32k clients per server) if at all possible. About 12 months ago we tried to run perMessageDeflate using the ws module but it tanked the server side performance. We decided not to pursue pmd as we couldn't get the cpu resource usage under control with a very busy server. We run msgpack over binary frames which gives us typically about a 20-30% reduction in ota bandwidth with little or no client/server performance hit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants