Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ED25519PrivateKeyValue public, add a way to instantiate ed25519Signer from it #213

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

arbll
Copy link
Contributor

@arbll arbll commented Jan 27, 2022

What does this PR do ?

  1. Makes Ed25519PrivateKeyValue public
  2. Adds a way to instantiate ed25519Signer from Ed25519PrivateKeyValue

With the change of interface for the keys there is no non-hacky way to use an ed25519 key that is not stored as a go-tuf specific marshaled JSON blob without re-implementing the signer interface.

@coveralls
Copy link

coveralls commented Jan 27, 2022

Pull Request Test Coverage Report for Build 1758509545

  • 2 of 10 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 70.068%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/keys/ed25519.go 2 10 20.0%
Totals Coverage Status
Change from base Build 1752556678: -0.2%
Covered Lines: 2156
Relevant Lines: 3077

💛 - Coveralls

@trishankatdatadog
Copy link
Member

asraa
asraa previously approved these changes Jan 27, 2022
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this is totally valid for a use case where you've done offline key generation.

Generally speaking, do we want some kind of import naming/method/something else? I'm happy with this, maybe the CLI should also allow for key imports at some point.

Co-authored-by: Ethan Lowman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants