feat: 536 Add Gitpod config to project #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
reviewed
Aug 7, 2023
There was a problem hiding this comment.
My thoughts are that go-tuf is not a complicated project in terms of various services that need to be set up beforehand to run/try it. For the time being, I don't see a lot of value in adding and potentially maintaining a custom config for it. Note that this does not stop anyone from loading go-tuf within a Gitpod workspace.
I see the benefits of using it, but I don't have a strong "yes" about adding it to the project. I'll let the other maintainers chime in too.
Disclaimer: I haven't used Gitpod so far so let me know if I'm missing something 👍
rdimitrov
force-pushed
the
536-add-gitpod-config
branch
from
e2e11bc
to
7a79369
Compare
rdimitrov
approved these changes
Sep 15, 2023
Signed-off-by: Edward Brough <[email protected]>
trishankatdatadog
force-pushed
the
536-add-gitpod-config
branch
from
60465fe
to
507b358
Compare
trishankatdatadog
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #536
Release Notes: Adds Gitpod config to the project$
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
Adds Gitpod config to the project$
Please verify and check that the pull request fulfills the following requirements: