Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use forward slash when splitting target names #612

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

kommendorkapten
Copy link
Member

@kommendorkapten kommendorkapten commented Feb 23, 2024

Even when running on Windows, the targets in the root uses forward slash.

Closes #605

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.51%. Comparing base (454b121) to head (b96df71).
Report is 24 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files          10       10           
  Lines        2123     2123           
=======================================
  Hits         1497     1497           
  Misses        505      505           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch! 🚀 I was expecting the issue to be in the library.

@rdimitrov rdimitrov merged commit 1e7978e into theupdateframework:master Feb 23, 2024
23 checks passed
@kommendorkapten kommendorkapten deleted the more-windows branch February 23, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit path handling for proper Windows support
3 participants