Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 0.15.0 release #1183

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Prepare 0.15.0 release #1183

merged 4 commits into from
Oct 23, 2020

Conversation

joshuagl
Copy link
Member

Fixes N/A

Description of the changes being introduced by the pull request:

Update docs/CHANGELOG.md and bump version number for a 0.15.0 release

Please verify and check that the pull request fulfills the following
requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@joshuagl
Prepare 0.15.0 release
8169b00 
Update docs/CHANGELOG.md and bump version number for a 0.15.0 release

Signed-off-by: Joshua Lock <[email protected]>
@joshuagl joshuagl mentioned this pull request Oct 21, 2020
Merged
3 tasks
@joshuagl
Bump securesystemslib from 0.16.0 to 0.17.0
33ac374 
We just released securesystemslib 0.17.0 and it would be better if tuf did
not pin the prior version.

https://pypi.org/project/securesystemslib/0.17.0/
https://github.com/secure-systems-lab/securesystemslib/releases/tag/v0.17.0

Signed-off-by: Joshua Lock <[email protected]>
@joshuagl
Add python-dateutil to test requirements
d992e8b 
tests/test_api.py uses python-dateutil, therefore ensure it is installed
for Travis and AppVeyor.

Signed-off-by: Joshua Lock <[email protected]>
@jku
Copy link
Member

jku commented Oct 22, 2020 •
edited
Loading

tox -e with-sslib-master:

ERROR: Double requirement given: securesystemslib[crypto,pynacl]==0.17.0 (from -r /home/travis/build/theupdateframework/tuf/requirements-pinned.txt (line 11)) (already in securesystemslib[crypto,pynacl] from git+http://github.com/secure-systems-lab/securesystemslib.git@master#egg=securesystemslib[crypto,pynacl], name='securesystemslib')

not related to this PR: just noticed it here. It already happened before the sslib 0.17.0 release as well.

This seems to happen because requirements-test.txt contains -r requirements-pinned.txt which contains securesystemslib[crypto,pynacl]==0.17.0 and pip seems to think that is not compatible with the git requirement... but how did that work before then: nothing important seems to have changed

@jku
Copy link
Member

jku commented Oct 22, 2020

tox -e with-sslib-master:

ERROR: Double requirement given: securesystemslib[crypto,pynacl]==0.17.0 (from -r /home/travis/build/theupdateframework/tuf/requirements-pinned.txt (line 11)) (already in securesystemslib[crypto,pynacl] from git+http://github.com/secure-systems-lab/securesystemslib.git@master#egg=securesystemslib[crypto,pynacl], name='securesystemslib')

Bisect tells me the problem is eb00d14 . I'll file an issue. I think this does not have to necessarily block the release: it looks like a CI configuration issue

lukpueh
lukpueh reviewed Oct 22, 2020
View reviewed changes
docs/CHANGELOG.md Outdated
### Added
* Simple TUF role metadata model in the `tuf.api` package for interacting with
metadata files directly, per-file without the overheads of reading and
writing the entire repository at once (#1112)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
writing the entire repository at once (#1112)
writing the entire repository at once (#1112, ##1177)

@lukpueh
Copy link
Member

lukpueh commented Oct 22, 2020

Just took the liberty to add few items to the changelog, I hope that works for @joshuagl. @jku, would you mind taking another quick glance at it?

jku
jku approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one typo fix

docs/CHANGELOG.md Outdated
`tuf.client.updater`s mirror configuration optional (#1153, #1166)
* Include LICENSE files with source distributions (#1162)
* Update Python version to be used in release instructions (#1163)
* Remove direct use of `coloroma` and dependency (#1180)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Remove direct use of `coloroma` and dependency (#1180)
* Remove direct use of `colorama` and dependency (#1180)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Thanks.

@lukpueh
Prepare 0.15.0 release (II)
10b9db1 
Update docs/CHANGELOG.md to include missing items.

Signed-off-by: Lukas Puehringer <[email protected]>
@lukpueh lukpueh merged commit 3934152 into theupdateframework:develop Oct 23, 2020
@joshuagl joshuagl deleted the joshuagl/tuf-0.15.0 branch August 10, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh left review comments

@jku jku jku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuagl @jku @lukpueh