tests: don't delete open files #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 12, 2021 11:55
Make sure test server processes are killed before the temporary directories are removed. Let Modified_Testcase handle the top-level temporary directory. Don't let Modified_testcase handle any subdirectories because: * teardown will try to remove them in the wrong order * removing the top level is enough Fixes theupdateframework#1344 Signed-off-by: Jussi Kukkonen <[email protected]>
Call the parent (Modified_Testcase) tearDown as the last thing in tearDown(). This is good practice anyway and in practice may prevent bugs where the instance needs to cleanup something before Modified_Testcase removes the temp dir. In practice there does not seem to be visible bugs in these tests (as the all have top level temp directory handling in tearDownClass()) Signed-off-by: Jussi Kukkonen <[email protected]>
These tests seem to try to remove temp files before the processes using those files had stopped. This likely lead to an error (and dangling temp files) on Windows, but Modified_Testcase hides the error Make sure temp directories are removed as the last thing in teardown. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
windows-file-in-use
branch
from
d589841
to
1902975
Compare
|
This does seem to fix #1344 (I tested by running the tests a few times with rzr's interpreter commit: all green). |
rzr
approved these changes
Apr 12, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three commits are basically the same thing: make sure tests remove temporary directories after any other teardown (most importantly: kill test servers before removing temp directories). First commit should actually fix a visible bug on windows CI (#1344), second is just good practice, third commit fixes a bug that is currently hidden by Modified_Testcase.
Long term thoughts: