Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian patches for debian branch #1872

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Feb 18, 2022

cc: @joshuagl feel free to merge before releasing on latest release and keep the work on this base , to align debian packaging team

Change-Id: Ib259d270399dbb9d1ebb0c133f4d9cda47c7ee75
Signed-off-by: Philippe Coval <[email protected]>
Signed-off-by: Philippe Coval <[email protected]>
system's tox can't be used for now
I'll add a change to support pip's one.

Change-Id: I98e1ddaeec93492bf3724fe1f0e0fdf0c80140d0
Signed-off-by: Philippe Coval <[email protected]>
User will have to use thoses already packaged in python directory

Change-Id: I0d985b21225a0553c8d0279582ce8307ad575fe0
Signed-off-by: Philippe Coval <[email protected]>
Fix wrong-section-according-to-package-name warning

Change-Id: I66d50145984f96d6798542319d9e1833b4627a6a
Signed-off-by: Philippe Coval <[email protected]>
Signed-off-by: Philippe Coval <[email protected]>
Change-Id: I4729f1a335b1860122293b629a69e852ceb1e858
Fix lintian warning upstream-metadata-file-is-missing

Signed-off-by: Philippe Coval <[email protected]>
Change-Id: Idb36dee8b356d5fe3146c10c36ba20e204c22b21
Signed-off-by: Philippe Coval <[email protected]>
Signed-off-by: Philippe Coval <[email protected]>
It's not enabled by default because pip will pull deps,
but it can be convient to try using:

    fakeroot ./debian/rules binary \
      PYBUILD_DISABLE_python3='' \
      DEB_BUILD_OPTIONS='' \
      TOX_OPTIONS="--sitepackages"

offline testing will need to be introduced later
(once debian's tox is supported with tuf)

Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/upstream/debian/review/master branch from 61b5f91 to 9ca04de Compare February 18, 2022 09:11
Those patches should net be forwarded to upstream's main branch

Relate-to: theupdateframework#263
Signed-off-by: Philippe Coval <[email protected]>
Signed-off-by: Philippe Coval <[email protected]>
Then part of patch can be upstreamed

Signed-off-by: Philippe Coval <[email protected]>
Signed-off-by: Philippe Coval <[email protected]>
Then set default CI/CD configuration path to "debian/salsa-ci.yml"
on https://salsa.debian.org/python-team/packages/tuf/-/settings/ci_cd

Signed-off-by: Philippe Coval <[email protected]>
Origin: Upstream
Thanks-to: @tumbleweed
Signed-off-by: Philippe Coval <[email protected]>
Reformat as suggested by DPT

Thanks-to: @tumbleweed
Signed-off-by: Philippe Coval <[email protected]>
Thanks-to: @tumbleweed
Forwarded: Not-Needed
Signed-off-by: Philippe Coval <[email protected]>
Generated by autodep8-python3

Thanks-to: @tumbleweed
Signed-off-by: Philippe Coval <[email protected]>
Cc: @tumbleweed
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/upstream/debian/review/master branch from 9ca04de to bfc069f Compare February 18, 2022 09:14
Others will be pulled implicitly.

Cc: @jcfp
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/upstream/debian/review/master branch from bfc069f to d9600ad Compare February 18, 2022 09:24
Copy link

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rzr thanks for the work. I left some review, please consider apply it. Also move that to the debian package in salsa.

Vcs-Git: https://github.com/theupdateframework/tuf.git
python3-securesystemslib,
tox
Standards-Version: 4.5.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be updated to 4.6.0.1

tox
Standards-Version: 4.5.1
Rules-Requires-Root: no
Vcs-Browser: https://salsa.debian.org/python-team/packages/tuf/-/tree/debian/master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend use https://salsa.debian.org/python-team/packages/tuf because here vcs-browser is pointing to a particular branch, and if that change in the future, that link would be incorrect.

cd "$AUTOPKGTEST_TMP/tests"

# Resolve "from tests import utils"
PYTHONPATH=".."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the purpose of autopkgtest is tests the packages as is installed. So, please remove PYTHONPATH.

@rzr
Copy link
Contributor Author

rzr commented Feb 18, 2022

Please add those changes in your branch to preserve history it will be easier to maintain debian's side too

@lukpueh
Copy link
Member

lukpueh commented Jun 1, 2022

Thanks for your efforts, @rzr! It does not look like upstream maintainers currently want to allocate time to package python-tuf for Debian. So I suggest to maintain Debian metadata and apply the patches of this PR in a downstream fork/mirror of python-tuf. Closing here...

@lukpueh lukpueh closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants