Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to sign release artifacts with verify_release #1979

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Add option to sign release artifacts with verify_release #1979

merged 4 commits into from
Apr 27, 2022

Commits on Apr 27, 2022

  1. build: fix success message in verify_release 

    Prior to theupdateframework#1946 the verify_release script was successful if both PyPI
and GitHub release artifacts matched the local build.

Now, if the `--skip-pypi` option is provided, the script can also
be successful if only the GitHub release artifacts match the local
build.

This commit splits the final success message in two separate
success messages, one for PyPI and one for GitHub.

Signed-off-by: Lukas Puehringer <[email protected]>
    @lukpueh
    lukpueh committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    e7544bf View commit details
    Browse the repository at this point in the history

  2. build: add 'gpg sign' option to verify_release 

    Add option to sign locally built release artifacts with gpg,
if they match the downloaded artifacts from GitHub, PyPI.

Signed-off-by: Lukas Puehringer <[email protected]>
    @lukpueh
    lukpueh committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    e56ff07 View commit details
    Browse the repository at this point in the history

  3. doc: describe signatures creation in RELEASE.md 

    Mention how to use verify_release with the recently added --sign
option to create signatures for a verified release.

Signed-off-by: Lukas Puehringer <[email protected]>
    @lukpueh
    lukpueh committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    8167889 View commit details
    Browse the repository at this point in the history

  4. build: minor style/wording fixes in verify_release 

    Co-authored-by: Joshua Lock <[email protected]>
Signed-off-by: Lukas Puehringer <[email protected]>
    @lukpueh @joshuagl
    lukpueh and joshuagl committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a3d5a37 View commit details
    Browse the repository at this point in the history