Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1862, added way to see full stack trace on error situations #2194

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

ameypd
Copy link
Contributor

@ameypd ameypd commented Nov 25, 2022

Passed verbosity as a parameter to download function. If exception occurs in the exception block, the value of verbosity is checked and if it is not equal to the default value(0), we print the stack trace using the traceback library.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3548645049

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.189%

Totals Coverage Status
Change from base Build 3525207970: 0.0%
Covered Lines: 1346
Relevant Lines: 1362

💛 - Coveralls

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking forward to this: I've just been working on some example client changes and no error messages has been annoying.

@jku jku merged commit 6ce8bb8 into theupdateframework:develop Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants