Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngclient: Fail gracefully on missing role #2197

Merged
merged 1 commit into from
Dec 16, 2022
Merged

ngclient: Fail gracefully on missing role #2197

merged 1 commit into from
Dec 16, 2022

Commits on Nov 28, 2022

  1. ngclient: Fail gracefully on missing role 

    If role is delegated but missing from snapshot, we currently raise a
undocumented KeyError: a generic RepositoryError seems better as callers
are expected to handle it (and adding a more specific error seems
useless as this is a repository software bug, not just expired metadata or
something).

The same check is also done later in TrustedMetadataSet but I think
keeping the check in both is clearest.

Fixes theupdateframework#2195

Signed-off-by: Jussi Kukkonen <[email protected]>
    @jku
    jku committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6450a3a View commit details
    Browse the repository at this point in the history